chore: fix ts-check comment ordering - #23386
Open
btea wants to merge 2 commits into
Open
Conversation
Member
|
I'd say the current behaviour is right though since any comment we put before an import could be describing that import, and we don't want to use comments as partitions to group imports. In this case we could add an extra new line after |
Contributor
Author
Yeah, that does solve the problem, though it looks a little strange. |
bluwy
approved these changes
Sep 2, 2026
bluwy
changed the title
sortImports.partitionByComment to true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://oxc.rs/docs/guide/usage/formatter/config-file-reference.html#sortimports-partitionbycomment
vite/eslint.config.js
Lines 2 to 3 in ee64401
After swapping the second and third lines and running
pnpm format, the third line becomes the first line, before the comment// @ts-check.